build: Add ability to generate package-level go protos#2
Merged
htuch merged 2 commits intocncf:masterfrom Aug 26, 2019
Merged
Conversation
Currently, this repository only generates cc and py protos. This change adds the ability to generate *.pb.go and *.pb.validate.go files for each package. - Example: `bazel build //udpa/data/orca/v1:pkg_go` Note that the option `go_package` is no longer needed in the proto files (and should not be added!). The go_package will be set automatically to match the path. - Example: udpa_service_orca_v1 Signed-off-by: Teju Nareddy <nareddyt@google.com>
nareddyt
commented
Aug 26, 2019
nareddyt
commented
Aug 26, 2019
htuch
reviewed
Aug 26, 2019
Signed-off-by: Teju Nareddy <nareddyt@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this repository only generates cc and py protos. This change adds the ability to generate *.pb.go and *.pb.validate.go files for each package.
bazel build //udpa/data/orca/v1:pkg_goNote that the option
go_packageis no longer needed in the proto files (and should not be added!). Thego_packagewill be set automatically to match the path.udpa_service_orca_v1in the generate protoPlease see my comments in this change for more details.
Note: This change is largely based on envoyproxy/envoy#8003
Signed-off-by: Teju Nareddy nareddyt@google.com