format display_name with dim_indices#187
Merged
VincentDary merged 1 commit intocmsis-svd:mainfrom Jan 25, 2024
ccalmels:display_name_dim
Merged
format display_name with dim_indices#187VincentDary merged 1 commit intocmsis-svd:mainfrom ccalmels:display_name_dim
VincentDary merged 1 commit intocmsis-svd:mainfrom
ccalmels:display_name_dim
Conversation
VincentDary
reviewed
Jan 25, 2024
According to the SVD specification: https://www.keil.com/pack/doc/CMSIS/SVD/html/elem_registers.html#elem_register, the 'displayName' child element of the register element can also take advantage of the '%s' syntax. The only difference with 'name' is that 'displayName' is optional. This patch duplicates the logic used by 'name' for 'displayName'. Because it is not clear if 'displayName' must contain '%s' let's handle any error.
VincentDary
approved these changes
Jan 25, 2024
Member
|
@ccalmels Thank's for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the SVD specification:
https://www.keil.com/pack/doc/CMSIS/SVD/html/elem_registers.html#elem_register, the 'displayName' child element of the register element can also take advantage of the '%s' syntax. The only difference with 'name' is that 'displayName' is optional.
This patch duplicates the logic used by 'name' for 'displayName'. Because it is not clear if 'displayName' must contain '%s' let's handle any error.