Skip to content

Salt character order should be randomized #41

@evancg37

Description

@evancg37

When a salt is generated, the order of the characters is always the same as the order of the salt sources. This makes the salt more predictable.

To demonstrate:

Image

Image

Order is always uppercase, lowercase, digits, symbols, then Latin 1 supplements. Changing the order of the salt sources just changes that order but the characters are still grouped together.

Instead, the salt should be generated with characters from the sources in a random order. So instead of something like "prayers851{?" the password could be "prayers5{18?" and the order of the salt sources wouldn't matter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions