Skip to content

Conversation

@chrisant996
Copy link
Contributor

The string.gsub() function in Lua always uses Lua patterns (which are similar to regular expressions). Cmder's custom prompt wants to perform simple plain text find/replace operations on strings. string.gsub() is the right Lua function for that, but since it always uses Lua patterns it's necessary to apply escaping to the input strings otherwise they can get misinterpreted and cause runtime errors.

For example, if the current working directory name contains a percent sign, such as literally "My%20Home".

This change fixes that. It introduces a helper function gsub_plain() which behaves like string.gsub() but applies appropriate escaping to convert the plain text input strings into the corresponding Lua patterns so that it can achieve plain text find/replace operations.

It also introduces separate helper functions for escaping the find and replace parameters for string.gsub(), since they have different escaping rules.

The `string.gsub()` function in Lua always uses Lua patterns (which are
similar to regular expressions).  Cmder's custom prompt wants to perform
simple plain text find/replace operations on strings.  `string.gsub()`
is the right Lua function for that, but since it always uses Lua
patterns it's necessary to apply escaping to the input strings otherwise
they can get misinterpreted and cause runtime errors.

For example, if the current working directory name contains a percent
sign, such as literally "My%20Home".

This change fixes that.  It introduces a helper function `gsub_plain()`
which behaves like `string.gsub()` but applies appropriate escaping to
convert the plain text input strings into the corresponding Lua
patterns so that it can achieve plain text find/replace operations.

It also introduces separate helper functions for escaping the `find` and
`replace` parameters for `string.gsub()`, since they have different
escaping rules.
@chrisant996 chrisant996 mentioned this pull request Jul 12, 2023
@DRSDavidSoft DRSDavidSoft self-assigned this Jul 16, 2023
@DRSDavidSoft DRSDavidSoft merged commit 3ea9728 into cmderdev:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants