Skip to content

Re-factor the build script to distinguish each step #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DRSDavidSoft merged 28 commits into from
Oct 17, 2022
Merged

Re-factor the build script to distinguish each step #2758

DRSDavidSoft merged 28 commits into from
Oct 17, 2022

Conversation

@DRSDavidSoft
Copy link
Contributor

@DRSDavidSoft DRSDavidSoft commented Oct 16, 2022 •
edited
Loading

This PR addresses #2757

Description

  • Added a -noVendor switch to bypass downloading vendor packages
  • Only check for msbuild.exe in path when the -Compile switch is used

👉 Note: The order of build has changed. Previously, the vendor packages were downloaded first, and then the launcher was subsequently built.

Since the launcher doesn't depend on vendored packages, and it might fail first, this PR moves the build step before downloading files, so if it fails the vendored files aren't downloaded and discarded.

@DRSDavidSoft DRSDavidSoft mentioned this pull request Oct 16, 2022
Closed
3 tasks
@DRSDavidSoft
Copy link
Contributor Author

DRSDavidSoft commented Oct 16, 2022 •
edited
Loading

@daxgames Please have a look, thanks!

📦 Download from GitHub Actions: https://github.com/cmderdev/cmder/actions/runs/3259741744

@DRSDavidSoft DRSDavidSoft mentioned this pull request Oct 16, 2022
Closed
@daxgames
Copy link
Member

daxgames commented Oct 16, 2022

@DRSDavidSoft are you adding Github gh as a Cmder component? If so I like it.

@DRSDavidSoft
Copy link
Contributor Author

DRSDavidSoft commented Oct 16, 2022

@DRSDavidSoft are you adding Github gh as a Cmder component? If so I like it.

That's also a good idea, but those functions are for the GitHub Actions / CI. I think gh could also be useful since it's only ~8 MB, but not the focus of this PR.

@daxgames
Copy link
Member

daxgames commented Oct 16, 2022 •
edited
Loading

I could see adding gh to the %CMDER_ROOT%/vendor/bin folder so it is automatically in the path. At this point it is easy enough to add after by a user that wants it.

@daxgames
Copy link
Member

daxgames commented Oct 16, 2022 •
edited
Loading

Odd it downloads from Github actions as Cmder.zip.zip and it is a zip in a zip.

@DRSDavidSoft
Copy link
Contributor Author

DRSDavidSoft commented Oct 16, 2022

@daxgames Sad to say, this is a known limitation by the authors (https://github.com/actions/upload-artifact#zipped-artifact-downloads). I haven't found anything yet to overcome this

@DRSDavidSoft DRSDavidSoft merged commit 5eacfc9 into cmderdev:master Oct 17, 2022
@DRSDavidSoft DRSDavidSoft self-assigned this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@DRSDavidSoft DRSDavidSoft

Labels

🍰 Component: PowerShell 🎨 Type: Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DRSDavidSoft @daxgames