-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
👀 Awaiting ResponseWaiting to hear back from the issue reporter.Waiting to hear back from the issue reporter.
Description
Purpose of the issue
- Bug report (encountered problems/errors)
- Feature request (request for new functionality)
- Question
Version Information
Cmder Version: 1.3.16
Windows Version: 10 2004 Build 19041.388
Locally installed Git: 2.27.0.windows.1
Embedded Git Version: 2.28.0.windows.1
Description of the issue
Inconsistent path between shell types causing inconsistent Git version and tools if Git is installed locally and a different version than embeded Git
- Git is installed locally in
C:\Program Files\Git. - Launching
cmd::Cmderandpowershell::powershellshells result in inconsistentpathbetween shell types causing inconsistent Unix tools availability. - If Git is installed locally and a different version than Cmder embedded Git then Git version is also inconsistent.
See screenshot of path from cmd::cmder, powershell::powershell, bash::bash split by delimiter into separate lines:
Result of inconsistencies in each shell:
cmd::cmder- Git Version: 2.28.0.windows.1
- Other Unix tools are available for use in the path.
powershell::powershell- Git Version: 2.27.0.windows.1
- Other Unix tools are NOT available for use in the path.
bash::bashGit Version: 2.27.0.windows.1- Git Version: 2.27.0.windows.1
- Other Unix tools are available for use in the path.
Proposed Fix:
- Use the newer Git version in all shells.
- If Git is installed and configured locally and embedded Git is older.
- Today we add Unix tools from the local install to the path for
cmd::cmderbut notpowershell::powershell - Proposal:
- Use the current path and make no changes regarding Git and Unix tools only add Cmder folders.
- Today we add Unix tools from the local install to the path for
- If Git is NOT installed and configured locally and we have embedded Git.
- Today we add
%cmder_root%\vendor\git-for-windows\cmdto the front of the path
and add%cmder_root%\vendor\git-for-windows\mingw64\binand%cmder_root%\vendor\git-for-windows\usr\binafterC:\Windowsto the end of the path
using embedded Git version and preferring Windows tools.
- Today we add
- If Git is installed and configured locally and embedded Git is newer
- Today we add Unix tools to the path for
cmd::cmderbut notpowershell::powershell - Match the path config of the locally installed version using the embedded git install
- Example 1: If locally installed Git only adds
C:\Program Files\Git\cmdto the path
thencmd::cmderandpowershell::powershellshould do the same by
adding%cmder_root%\vendor\git-for-windows\cmdto the front of the path
overriding locally installed Git using embedded version. - Example 2: If locally installed Git adds
C:\Program Files\Git\cmdto the path and alsoC:\Program Files\mingw64\binandC:\Program Files\usr\binafterC:\Windows
thencmd::cmderandpowershell::powershellshould do the same by
adding%cmder_root%\vendor\git-for-windows\cmdto the front of the path
and addingC:\Program Files\mingw64\binandC:\Program Files\usr\binafterC:\Windowsto the end of the path
overriding locally installed Git using embedded version and preferring Windows tools. - Example 3: If locally installed Git adds
C:\Program Files\Git\cmdto the path andC:\Program Files\mingw64\binandC:\Program Files\usr\binbeforeC:\Windows\System32
thencmd::cmderandpowershell::powershellshould do the same by
adding%cmder_root%\vendor\git-for-windows\cmdandC:\Program Files\mingw64\binandC:\Program Files\usr\binto the front of the path
overriding locally installed version and preferring Unix tools.
- Example 1: If locally installed Git only adds
- Today we add Unix tools to the path for
Comments?
Metadata
Metadata
Assignees
Labels
👀 Awaiting ResponseWaiting to hear back from the issue reporter.Waiting to hear back from the issue reporter.
