Add CHECK_ALL_WARNINGS to force test to fail on any Warning.#11
Closed
Add CHECK_ALL_WARNINGS to force test to fail on any Warning.#11
Conversation
|
Thanks @cmarmo ! I think trying to address warnings in the test suite would be very useful, but I'm less sure that failing on them would be a good idea cf scikit-learn#5685 (comment) |
This was referenced Mar 6, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Local test for scikit-learn issues #5685 and #10158
What does this implement/fix? Explain your changes.
Add CHECK_ALL_WARNINGS option to force test to fail on any Warning.