Skip to content

Conversation

@clue
Copy link
Owner

@clue clue commented Nov 27, 2020

This changeset adds support for PHP 8 (released just yesterday). PHP 8 uses Socket objects instead of socket resource and has some stricter error reporting semantics, it otherwise works as-is.

I've also had to skip one test which currently causes a SEGFAULT on PHP 8, this should probably be reported upstream:

class Test extends PHPUnit\Framework\TestCase
{
    public function testA()
    {
        $socket = socket_create_listen(0);
        socket_set_nonblock($socket);
        $ret = socket_accept($socket);

        $this->assertFalse($ret);
    }
}

Builds on top of #59 and #60

@clue clue added this to the v1.5.0 milestone Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants