Skip to content

Support all subscription operator pattern in IndexExpr#206

Merged
makenowjust merged 7 commits intocloudspannerecosystem:mainfrom
apstndb:feature/subscript
Nov 22, 2024
Merged

Support all subscription operator pattern in IndexExpr#206
makenowjust merged 7 commits intocloudspannerecosystem:mainfrom
apstndb:feature/subscript

Conversation

@apstndb
Copy link
Copy Markdown
Contributor

@apstndb apstndb commented Nov 21, 2024

This PR implements subscription operators in ast.Expr.

Breaking change:

  • Index in IndexExpr is now SubscriptSpecifier interface.
  • Ordinal in IndexExpr has been removed. See SubscriptSpecifierKeyword.

Related issues:

Copy link
Copy Markdown
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@makenowjust makenowjust merged commit 75946e1 into cloudspannerecosystem:main Nov 22, 2024
@apstndb apstndb deleted the feature/subscript branch November 22, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement generalized subscript operators

2 participants