Skip to content

Implement ALTER COLUMN DROP DEFAULT#166

Merged
makenowjust merged 5 commits intocloudspannerecosystem:mainfrom
apstndb:feature/alter-column-drop-default
Oct 22, 2024
Merged

Implement ALTER COLUMN DROP DEFAULT#166
makenowjust merged 5 commits intocloudspannerecosystem:mainfrom
apstndb:feature/alter-column-drop-default

Conversation

@apstndb
Copy link
Copy Markdown
Contributor

@apstndb apstndb commented Oct 21, 2024

This PR implements ALTER COLUMN column_name DROP DEFAULT.
Also it introduces ColumnAlteration interface to simplify ALTER COLUMN actions.

fix #92

@makenowjust
Copy link
Copy Markdown
Collaborator

IMO, we could remove pos_test.go. I'm not sure why only a test for AlterColumnSet positions exists.

@apstndb
Copy link
Copy Markdown
Contributor Author

apstndb commented Oct 22, 2024

Yeah, I'm happy to remove it.

Copy link
Copy Markdown
Collaborator

@makenowjust makenowjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@makenowjust makenowjust merged commit 91ea26d into cloudspannerecosystem:main Oct 22, 2024
@apstndb apstndb deleted the feature/alter-column-drop-default branch October 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatibility: ALTER COLUMN DROP DEFAULT

2 participants