Skip to content

Implement HAVING MIN/MAX and RESPECT/IGNORE NULLS#154

Merged
makenowjust merged 6 commits intocloudspannerecosystem:mainfrom
apstndb:feature/aggregate-function-calls
Oct 20, 2024
Merged

Implement HAVING MIN/MAX and RESPECT/IGNORE NULLS#154
makenowjust merged 6 commits intocloudspannerecosystem:mainfrom
apstndb:feature/aggregate-function-calls

Conversation

@apstndb
Copy link
Copy Markdown
Contributor

@apstndb apstndb commented Oct 20, 2024 •
edited
Loading

This PR implements the current aggregate function call syntax.

https://cloud.google.com/spanner/docs/reference/standard-sql/aggregate-function-calls#aggregate_function_call_syntax

function_name(
  [ DISTINCT ]
  function_arguments
  [ { IGNORE | RESPECT } NULLS ]
  [ HAVING { MAX | MIN } having_expression ]
)

Note

  • The names NullHandlingModifier and HavingModifier are borrowed from ZetaSQL
  • COUNT(*) doesn't support these modifiers, so CountStarExpr is not updated.

fix #88

makenowjust
makenowjust approved these changes Oct 20, 2024
View reviewed changes
apstndb and others added 2 commits October 20, 2024 15:58
@apstndb @makenowjust
Update ast/ast.go
33d99c7 
Co-authored-by: Hiroya Fujinami <make.just.on@gmail.com>
@apstndb
Merge remote-tracking branch 'origin/main' into feature/aggregate-fun…
76e7e1f 
…ction-calls
@apstndb
Copy link
Copy Markdown
Contributor Author

apstndb commented Oct 20, 2024 •
edited
Loading

Conflict resolved and suggestion applied.

@makenowjust makenowjust merged commit 90f4dcb into cloudspannerecosystem:main Oct 20, 2024
@makenowjust
Copy link
Copy Markdown
Collaborator

makenowjust commented Oct 20, 2024

@apstndb Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makenowjust makenowjust makenowjust approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support current spec of aggregate function calls

2 participants

@apstndb @makenowjust