Commit More Examples #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I have some nitpicky spacing suggestions, but nothing that needs a second look. |
href
approved these changes
Aug 27, 2024
| apiVersion: v1 | ||
| data: | ||
| nginx.conf: |2 | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: I think this space, and a bunch of the double spaces in this config are not needed.
Contributor
Author
There was a problem hiding this comment.
I have created this part using kubectl create configmap --from-file= using the original nginx config file from the image. Therefore, I prefer to not fiddly around with this part more than necessary. I hope this is okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds examples for:
Feel free to suggest modifications.