Use a more flexible port to pool mapping #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously loadbalancer pools were named as a combination of the service port protocol and outward bound port: - `service.spec.ports[].protocol` - `service.spec.ports[].port` Since a name mis-match causes a pool to be recreated - an operation that takes around 30-45 seconds - a change in the port number caused the pool and its members to be recreated. Since Kubernetes has the option to set a unique name for each service port, we can offer an approach that allows to change the port, without pool recreation in some cases: - If a service has only one port with no name and the port changes. - If a service uses names but keeps the names stable when changing ports. In such cases, only the listener has to be re-created, which can be done in 10-15 seconds. There's still a slight downtime that has to be expected, but it is much shorter. When the name changes, the pool still has to be recreated, which will be a bit unexpected, but for deployments that would like to add/remove/change a port with minimal downtime, there's now a way.
3424773 to
cb05334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously loadbalancer pools were named as a combination of the service port protocol and outward bound port:
service.spec.ports[].protocolservice.spec.ports[].portSince a name mis-match causes a pool to be recreated - an operation that takes around 30-45 seconds - a change in the port number caused the pool and its members to be recreated.
Since Kubernetes has the option to set a unique name for each service port, we can offer an approach that allows to change the port, without pool recreation in some cases:
In such cases, only the listener has to be re-created, which can be done in 10-15 seconds. There's still a slight downtime that has to be expected, but it is much shorter.
When the name changes, the pool still has to be recreated, which will be a bit unexpected, but for deployments that would like to add/remove/change a port with minimal downtime, there's now a way.