Skip to content

fix(api): make getFileList respect skipSnackbar#336

Merged
HFO4 merged 1 commit into
cloudreve:masterfrom
AnranYus:master
Apr 14, 2026
Merged

fix(api): make getFileList respect skipSnackbar#336
HFO4 merged 1 commit into
cloudreve:masterfrom
AnranYus:master

Conversation

@AnranYus

@AnranYus AnranYus commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

@CLAassistant

CLAassistant commented Apr 8, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@YUDONGLING

Copy link
Copy Markdown
Member

@AnranYus Do they have any relationship?

@AnranYus

AnranYus commented Apr 8, 2026

Copy link
Copy Markdown
Contributor Author

@AnranYus Do they have any relationship?

This will now trigger a toast notification when a downloaded file is deleted, providing a meaningful prompt for the user, I think this is also the original reason why this parameter was introduced.

@YUDONGLING

YUDONGLING commented Apr 8, 2026

Copy link
Copy Markdown
Member

We already have this? This also applies when you enter from saved short link.

截屏2026-04-09 03 24 18

@AnranYus

AnranYus commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

We already have this? This also applies when you enter from saved short link.

截屏2026-04-09 03 24 18
image

Your screenshot shows that when a shared file is deleted, the sharing link becomes invalid automatically after it has been opened, which is working as expected. However, in the following flow — open the sharing link → save the file → delete the original file — the saved shortcut does not become invalid accordingly. When the user clicks Download, the only indication that the file has been deleted is the returned HTTP response.

@YUDONGLING YUDONGLING left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro version has already included this in the previous versions, fix to Community verison only.

@YUDONGLING

Copy link
Copy Markdown
Member

We already have this? This also applies when you enter from saved short link.
截屏2026-04-09 03 24 18

image Your screenshot shows that when a shared file is deleted, the sharing link becomes invalid automatically after it has been opened, which is working as expected. However, in the following flow — open the sharing link → save the file → delete the original file — the saved shortcut does not become invalid accordingly. When the user clicks Download, the only indication that the file has been deleted is the returned HTTP response.

Yes in Pro version this is included, but seems missing in Community verison.
Thanks!

@HFO4

HFO4 commented Apr 14, 2026

Copy link
Copy Markdown
Member

Nice catch, thanks!

@HFO4 HFO4 merged commit 31c2873 into cloudreve:master Apr 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After deleting the file, it still exists in "Shared with Me" And "My Files"

4 participants