fix(writers): Assert unimplemented interface at compile-time#857
Merged
kodiakhq[bot] merged 1 commit intomainfrom May 10, 2023
Merged
fix(writers): Assert unimplemented interface at compile-time#857kodiakhq[bot] merged 1 commit intomainfrom
kodiakhq[bot] merged 1 commit intomainfrom
Conversation
candiduslynx
commented
May 10, 2023
| type UnimplementedUnmanagedWriter struct{} | ||
|
|
||
| func (*UnimplementedUnmanagedWriter) Write(context.Context, schema.Schemas, <-chan arrow.Record) error { | ||
| func (UnimplementedUnmanagedWriter) Write(context.Context, schema.Tables, <-chan arrow.Record) error { |
Contributor
Author
There was a problem hiding this comment.
using value receiver here as empty struct consumes no memory
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 48.09% 48.09%
=======================================
Files 29 29
Lines 2439 2439
=======================================
Hits 1173 1173
Misses 1164 1164
Partials 102 102 ☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.