Skip to content

chore(test): Table for write append should also be modeled with timestamp#845

Merged
kodiakhq[bot] merged 1 commit intomainfrom
candiduslynx-patch-1
May 4, 2023
Merged

chore(test): Table for write append should also be modeled with timestamp#845
kodiakhq[bot] merged 1 commit intomainfrom
candiduslynx-patch-1

Conversation

@candiduslynx
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx commented May 3, 2023

Discovered while performing testing for #818 in cloudquery/cloudquery#10557

@codecov
Copy link
Copy Markdown

codecov bot commented May 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (301152b) 47.18% compared to head (e891e51) 47.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #845   +/-   ##
=======================================
  Coverage   47.18%   47.18%           
=======================================
  Files          76       76           
  Lines        7841     7841           
=======================================
  Hits         3700     3700           
  Misses       3642     3642           
  Partials      499      499           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 3, 2023

⏱️ Benchmark results

Comparing with 301152b

  • DefaultConcurrencyDFS-2 resources/s: 11,004 ⬇️ 2.35% decrease vs. 301152b
  • DefaultConcurrencyRoundRobin-2 resources/s: 11,063 ⬇️ 5.22% decrease vs. 301152b
  • Glob-2 ns/op: 189.4 ⬆️ 1.95% increase vs. 301152b
  • TablesWithChildrenDFS-2 resources/s: 26,794 ⬆️ 2.17% increase vs. 301152b
  • TablesWithChildrenRoundRobin-2 resources/s: 27,903 ⬆️ 1.70% increase vs. 301152b
  • TablesWithRateLimitingDFS-2 resources/s: 28.3 ⬇️ 0.42% decrease vs. 301152b
  • TablesWithRateLimitingRoundRobin-2 resources/s: 821.8 ⬇️ 1.10% decrease vs. 301152b
  • BufferedScanner-2 ns/op: 9.393 ⬆️ 0.20% increase vs. 301152b
  • LogReader-2 ns/op: 31.48 ⬆️ 2.57% increase vs. 301152b

@kodiakhq kodiakhq bot merged commit b07fd22 into main May 4, 2023
@kodiakhq kodiakhq bot deleted the candiduslynx-patch-1 branch May 4, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants