Skip to content

chore(ci): Add timeout to CI jobs#816

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:chore/ci_add_timeout
Apr 30, 2023
Merged

chore(ci): Add timeout to CI jobs#816
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:chore/ci_add_timeout

Conversation

@erezrokah
Copy link
Member

@erezrokah erezrokah commented Apr 20, 2023

Summary

The default GitHub Actions timeout is 6 hours. This PR sets all jobs timeouts to 10m to avoid things like:
https://github.com/cloudquery/plugin-sdk/actions/runs/4753306214/jobs/8444724190 (This Windows job timed out after 6 hours)


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@github-actions
Copy link

⏱️ Benchmark results

Comparing with fb2929f

  • DefaultConcurrencyDFS-2 resources/s: 10,855 ⬆️ 1.44% increase vs. fb2929f
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,298 ⬇️ 0.74% decrease vs. fb2929f
  • Glob-2 ns/op: 234.2 ⬇️ 7.56% decrease vs. fb2929f
  • TablesWithChildrenDFS-2 resources/s: 27,412 ⬆️ 6.91% increase vs. fb2929f
  • TablesWithChildrenRoundRobin-2 resources/s: 25,801 ⬆️ 6.87% increase vs. fb2929f
  • TablesWithRateLimitingDFS-2 resources/s: 28.2 ⬇️ 0.57% decrease vs. fb2929f
  • TablesWithRateLimitingRoundRobin-2 resources/s: 876.8 ⬆️ 6.09% increase vs. fb2929f
  • BufferedScanner-2 ns/op: 10.79 ⬇️ 4.36% decrease vs. fb2929f
  • LogReader-2 ns/op: 35.57 ⬇️ 10.88% decrease vs. fb2929f

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fa51c80) 47.18% compared to head (fdb4c4d) 47.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #816   +/-   ##
=======================================
  Coverage   47.18%   47.18%           
=======================================
  Files          76       76           
  Lines        7845     7845           
=======================================
  Hits         3702     3702           
  Misses       3643     3643           
  Partials      500      500           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kodiakhq kodiakhq bot merged commit d3e88ba into cloudquery:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants