chore(ci): Add timeout to CI jobs#816
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Apr 30, 2023
Merged
Conversation
⏱️ Benchmark resultsComparing with fb2929f
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 47.18% 47.18%
=======================================
Files 76 76
Lines 7845 7845
=======================================
Hits 3702 3702
Misses 3643 3643
Partials 500 500 ☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
Apr 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default GitHub Actions timeout is 6 hours. This PR sets all jobs timeouts to 10m to avoid things like:
https://github.com/cloudquery/plugin-sdk/actions/runs/4753306214/jobs/8444724190 (This Windows job timed out after 6 hours)
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)