Skip to content

chore(docs): Add issue templates#731

Merged
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
erezrokah:chore/issue_templates
Mar 15, 2023
Merged

chore(docs): Add issue templates#731
kodiakhq[bot] merged 1 commit intocloudquery:mainfrom
erezrokah:chore/issue_templates

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Mar 14, 2023

Summary

Part of cloudquery/cloudquery#8946


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a0a58c4) 48.82% compared to head (ebe3a72) 48.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files          70       70           
  Lines        6923     6923           
=======================================
  Hits         3380     3380           
  Misses       3077     3077           
  Partials      466      466           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown

⏱️ Benchmark results

Comparing with ac55bec

  • DefaultConcurrencyDFS-2 resources/s: 10,833 ⬆️ 2.13% increase vs. ac55bec
  • DefaultConcurrencyRoundRobin-2 resources/s: 11,107 ⬇️ 12.35% decrease vs. ac55bec
  • Glob-2 ns/op: 179.4 ⬆️ 3.73% increase vs. ac55bec
  • TablesWithChildrenDFS-2 resources/s: 28,913 ⬆️ 2.93% increase vs. ac55bec
  • TablesWithChildrenRoundRobin-2 resources/s: 30,705 ⬆️ 10.46% increase vs. ac55bec
  • TablesWithRateLimitingDFS-2 resources/s: 28.38 ⬆️ 0.11% increase vs. ac55bec
  • TablesWithRateLimitingRoundRobin-2 resources/s: 813 ⬇️ 3.48% decrease vs. ac55bec
  • BufferedScanner-2 ns/op: 9.394 ⬇️ 1.83% decrease vs. ac55bec
  • LogReader-2 ns/op: 30.5 (no change)

@erezrokah erezrokah requested review from disq and removed request for amanenk March 14, 2023 15:49
@kodiakhq kodiakhq bot merged commit c9f95a5 into cloudquery:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants