fix(types-timestamptz): Handle MarshalText and String for pointer receivers#596
Closed
erezrokah wants to merge 1 commit intocloudquery:mainfrom
Closed
fix(types-timestamptz): Handle MarshalText and String for pointer receivers#596erezrokah wants to merge 1 commit intocloudquery:mainfrom
MarshalText and String for pointer receivers#596erezrokah wants to merge 1 commit intocloudquery:mainfrom
Conversation
MarshalText and String support on pointer receiversMarshalText and String for pointer receivers
⏱️ Benchmark resultsComparing with 506d4cc
|
5 tasks
Contributor
|
@erezrokah can you link to where this is used/current failing in the plugins ? |
Member
Author
|
I thought I needed it for GCP, but actually the fix there was to override the resolver. I still think it makes sense as it's common to declare methods on pointer receivers. I don't think it's super important at the moment so we can close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to also try calling
MarshalTextandStringwhen those methods are declared on a pointer receiverUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)