fix(destinations): Set correct status code for context errors#486
Closed
erezrokah wants to merge 2 commits intocloudquery:mainfrom
Closed
fix(destinations): Set correct status code for context errors#486erezrokah wants to merge 2 commits intocloudquery:mainfrom
erezrokah wants to merge 2 commits intocloudquery:mainfrom
Conversation
⏱️ Benchmark resultsComparing with 8dcbe8d
|
5 tasks
candiduslynx
approved these changes
Dec 21, 2022
Co-authored-by: candiduslynx <candiduslynx@users.noreply.github.com>
candiduslynx
approved these changes
Dec 21, 2022
Member
Author
|
Closing since I think the fixes in #530 should be enough for now. We can re-visit this in the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This ensures relevant status code (
codes.DeadlineExceededorcodes.Canceled) is set for the gRPC error.Without this fix the status will always be
codes.Unknown.Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)