Skip to content

refactor: Reduce nesting in destination server code write #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erezrokah wants to merge 3 commits into from
Closed

refactor: Reduce nesting in destination server code write #463

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4766d2
refactor: Reduce nesting in destination server code
erezrokah Dec 6, 2022
caea486
Merge branch 'main' into refactor/reduce_nesting
erezrokah Dec 21, 2022
6b16ebf
chore(style): Format code
erezrokah Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions internal/servers/destinations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ func (s *DestinationServer) Write2(msg pb.Destination_Write2Server) error {

for {
r, err := msg.Recv()
if err != nil {
if err == io.EOF {
close(resources)
if err := eg.Wait(); err != nil {
return status.Errorf(codes.Internal, "failed to wait for plugin: %v", err)
}
return msg.SendAndClose(&pb.Write2_Response{})
if err == io.EOF {
close(resources)
if err := eg.Wait(); err != nil {
return status.Errorf(codes.Internal, "failed to wait for plugin: %v", err)
}
return msg.SendAndClose(&pb.Write2_Response{})
}
if err != nil {
close(resources)
if err := eg.Wait(); err != nil {
s.Logger.Error().Err(err).Msg("got error. failed to wait for plugin")
Expand Down