chore: Add more options to destination testing#426
Merged
kodiakhq[bot] merged 6 commits intomainfrom Nov 24, 2022
Merged
Conversation
hermanschaaf
suggested changes
Nov 23, 2022
| reValidColumnName = regexp.MustCompile(`^[a-z_][a-z\d_]*$`) | ||
| ) | ||
|
|
||
| func (tt Tables) FlattenTables() Tables { |
Contributor
There was a problem hiding this comment.
Looks good, but we should probably have a small test for this functionality :)
plugins/destination_testing.go
Outdated
| SkipOverwrite bool | ||
| SkipDeleteStale bool | ||
| SkipAppend bool | ||
| SkipAppendTwice bool |
Contributor
There was a problem hiding this comment.
Could we add a comment to explain what this option does? The others are fairly self-explanatory, but I'm not sure about this one
Contributor
There was a problem hiding this comment.
Oh okay, reading the code, maybe it could be called SkipSecondAppend?
Contributor
There was a problem hiding this comment.
Also, I'm curious why this is useful as a test case 🤔
Contributor
Author
There was a problem hiding this comment.
It is useful in cases like cloud storage where you can't append to an existing object the moment you closed the file as it's immutable while locally you can and of-course for PostgreSQL it's all valid.
hermanschaaf
approved these changes
Nov 24, 2022
…gin-sdk into test/improve_dest_testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added another option needed for destination testing. Needed by this PR: cloudquery/cloudquery#4902
Also, added a
FlattenTablesfunction forTablestype