feat: Add Name() to source and destination clients#29
Merged
yevgenypats merged 3 commits intomainfrom Sep 1, 2022
Merged
Conversation
yevgenypats
reviewed
Sep 1, 2022
clients/destination.go
Outdated
| } | ||
|
|
||
| func (c *DestinationClient) Name(ctx context.Context) (string, error) { | ||
| res, err := c.pbClient.GetExampleConfig(ctx, &pb.GetExampleConfig_Request{}) |
Contributor
There was a problem hiding this comment.
Should we create a protobuf call just for that?
Contributor
Author
There was a problem hiding this comment.
Ok, will update 👍
Contributor
Author
There was a problem hiding this comment.
Done; the RPC calls have been split into three separate ones now (name, version, config)
yevgenypats
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it uses the example config GRPC call to get the name (previously not exposed via the client). In the future we could change it for a
NameGRPC call, if we wanted.