Skip to content

chore: Remove unused OTEL flags#1896

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:chore/remove_undocumented_flags
Sep 18, 2024
Merged

chore: Remove unused OTEL flags#1896
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:chore/remove_undocumented_flags

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Sep 18, 2024

Summary

otel-endpoint-urlpath and otel-endpoint-headers are not documented, cannot be used via a spec option like otel-endpoint and otel-endpoint-insecure (only via direct invocation of the plugin's binary), and make it harder to support multiple endpoints.

This PR removes them until we actually need them


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@kodiakhq kodiakhq bot merged commit 8f20a07 into cloudquery:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants