feat: Resolve proto timestamp to schema.TypeTimestamp#135
Closed
candiduslynx wants to merge 2 commits intomainfrom
Closed
feat: Resolve proto timestamp to schema.TypeTimestamp#135candiduslynx wants to merge 2 commits intomainfrom
schema.TypeTimestamp#135candiduslynx wants to merge 2 commits intomainfrom
Conversation
erezrokah
reviewed
Sep 20, 2022
| t := v.PkgPath() + "." + v.Name() | ||
| if t == "time.Time" { | ||
| switch t := v.PkgPath() + "." + v.Name(); t { | ||
| case "time.Time", "google.golang.org/protobuf/types/known/timestamppb.Timestamp": |
Member
There was a problem hiding this comment.
I'm not sure we want the SDK to be aware of specific non built-in Go types
Contributor
There was a problem hiding this comment.
I agree with @erezrokah . Here it's not so bad but in column.go it makes an import which will cause all plugins to import unrelated libraries and grow in size which we should be careful with.
Contributor
Author
There was a problem hiding this comment.
Well, at the very least we can do a custom mapping for the type, but we need a custom mapper for the value as well (timestamppb.Timestamp -> time.Time)
Member
There was a problem hiding this comment.
How about check for an interface? here it's documented that there's an AsTime() time.Time method... Maybe define that as timestamppb's signature and use it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)