Merged
Conversation
It seems like the last entry takes precedence, so Erez was being required on all reviews. I hope this change will make it so that any one of us can approve it 🤞
candiduslynx
approved these changes
Sep 1, 2023
⏱️ Benchmark results
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
=======================================
Coverage 48.30% 48.30%
=======================================
Files 87 87
Lines 8151 8151
=======================================
Hits 3937 3937
Misses 3857 3857
Partials 357 357 ☔ View full report in Codecov by Sentry. |
erezrokah
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the last entry takes precedence, so Erez was being required on all reviews. I hope this change will make it so that any one of us can approve it and not that all of us will be required 🤞