chore(refactor): Make interpolateAllResources more readable#106
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Sep 15, 2022
Merged
chore(refactor): Make interpolateAllResources more readable#106kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
interpolateAllResources more readable#106kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
interpolateAllResources more readable
f19934e to
a485c25
Compare
yevgenypats
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It took me a bit of time to understand what's the purpose of this function as it uses negated logic and also
len(tables) > 1hides the equality check.Did a bit of refactoring to make it easier (I hope) to understand and added tests for it
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)