fix: Remove description from docs#92
Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom Sep 13, 2022
Merged
Conversation
d8e275a to
f411ada
Compare
f411ada to
5fc1128
Compare
Contributor
|
FWIW, some columns do still have descriptions, but agree, let's remove it from the docs for now since they're mostly empty. |
hermanschaaf
approved these changes
Sep 12, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 13, 2022
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.2...v0.5.0) (2022-09-13) ### ⚠ BREAKING CHANGES * Enable var names lint rule and fix issues (#88) * Disable default completion command (#96) ### Features * Disable default completion command ([#96](#96)) ([67fca4b](67fca4b)) ### Bug Fixes * Enable var names lint rule and fix issues ([#88](#88)) ([4a752b5](4a752b5)) * Remove description from docs ([#92](#92)) ([7df58df](7df58df)) * Remove empty test and enable some lint rules ([#90](#90)) ([514fba4](514fba4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We don't generate the descriptions anymore (I think), so we should not generate them with the docs.
Also switched to snapshot testing so the output files are separated from the code.
Another possible implementation is to add an option to enable/disable the description column
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)