Skip to content

fix(json): Use GetOneForMarshal instead of deserialization-serialization cycle#834

Merged
kodiakhq[bot] merged 3 commits intomainfrom
chore/validate-unescape
Apr 30, 2023
Merged

fix(json): Use GetOneForMarshal instead of deserialization-serialization cycle#834
kodiakhq[bot] merged 3 commits intomainfrom
chore/validate-unescape

Conversation

@candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Apr 30, 2023

BEGIN_COMMIT_OVERRIDE
fix(json): Use GetOneForMarshal instead of deserialization-serialization cycle (#834)
END_COMMIT_OVERRIDE

@github-actions
Copy link

github-actions bot commented Apr 30, 2023

⏱️ Benchmark results

  • DefaultConcurrencyDFS-2 resources/s: 9,891
  • DefaultConcurrencyRoundRobin-2 resources/s: 12,444
  • Glob-2 ns/op: 195.1
  • TablesWithChildrenDFS-2 resources/s: 30,925
  • TablesWithChildrenRoundRobin-2 resources/s: 26,709
  • TablesWithRateLimitingDFS-2 resources/s: 28.22
  • TablesWithRateLimitingRoundRobin-2 resources/s: 841.8
  • BufferedScanner-2 ns/op: 9.412
  • LogReader-2 ns/op: 30.67

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (d3e88ba) 47.18% compared to head (9be75e9) 47.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   47.18%   47.18%   -0.01%     
==========================================
  Files          76       76              
  Lines        7845     7841       -4     
==========================================
- Hits         3702     3700       -2     
+ Misses       3643     3642       -1     
+ Partials      500      499       -1     
Impacted Files Coverage Δ
types/json.go 60.62% <100.00%> (+0.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kodiakhq kodiakhq bot merged commit 6fb7c1c into main Apr 30, 2023
@kodiakhq kodiakhq bot deleted the chore/validate-unescape branch April 30, 2023 14:26
@candiduslynx candiduslynx changed the title chore(tests): Validate the unescaped data stored as escaped fix(json): Use GetOneForMarshal instead of deserialization-serialization cycle Apr 30, 2023
kodiakhq bot pushed a commit that referenced this pull request May 2, 2023
🤖 I have created a release *beep* *boop*
---


## [2.5.2](v2.5.1...v2.5.2) (2023-05-02)


### Bug Fixes

* **deps:** Update github.com/apache/arrow/go/v12 digest to 0ea1a10 ([#836](#836)) ([5561fa1](5561fa1))
* **deps:** Update golang.org/x/exp digest to 47ecfdc ([#837](#837)) ([bb56f9c](bb56f9c))
* **deps:** Update golang.org/x/xerrors digest to 04be3eb ([#838](#838)) ([42d4517](42d4517))
* **deps:** Update google.golang.org/genproto digest to daa745c ([#839](#839)) ([1285222](1285222))
* **deps:** Update module github.com/avast/retry-go/v4 to v4.3.4 ([#840](#840)) ([47da73d](47da73d))
* Destination migration testing using incorrect mode ([#822](#822)) ([fa51c80](fa51c80))
* **json:** Use `GetOneForMarshal` instead of deserialization-serialization cycle ([#834](#834)) ([6fb7c1c](6fb7c1c))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants