feat: Add version discovery service#619
Merged
kodiakhq[bot] merged 4 commits intomainfrom Jan 23, 2023
Merged
Conversation
⏱️ Benchmark resultsComparing with 0d3ff48
|
erezrokah
approved these changes
Jan 23, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks great 🚀 I wish we could avoid spawning a new process only to get the versions, but I don't see a way around it at the moment
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
Contributor
Author
Yeah I thought about this as well but yeah don't see an easy way around it, at least not without some refactoring :( |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 23, 2023
🤖 I have created a release *beep* *boop* --- ## [1.28.0](v1.27.0...v1.28.0) (2023-01-23) ### Features * Add version discovery service ([#619](#619)) ([33ab32a](33ab32a)) * Dynamic tables and introduce proto versioning ([#610](#610)) ([448232c](448232c)) ### Bug Fixes * **clients:** Update `log line too long` message ([#611](#611)) ([0d3ff48](0d3ff48)) * Simplify client naming conventions ([#617](#617)) ([38b136b](38b136b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds discovery service to support multiple versions. Follow-up to this: #610