-
Notifications
You must be signed in to change notification settings - Fork 26
Bug(env-expanding): Commented env variables should not be expanded #613
Copy link
Copy link
Closed
Description
Describe the bug
Given the following configuration:
kind: source
spec:
name: "azure"
path: "cloudquery/azure"
version: "v3.3.0"
tables: ["*"]
destinations: ["postgresql"]
concurrency: 1000
spec:
subscriptions:
- 21e0d134-5da8-4754-8587-c58425d93de5
---
kind: destination
spec:
name: "postgresql"
path: "cloudquery/postgresql"
version: "v2.0.5"
write_mode: "overwrite-delete-stale"
spec:
# connection_string: ${TEST_STRING}
connection_string: postgresql://postgres:pass@localhost:5432/postgresRunning cloudquery sync <path-to-config> you get an error if the TEST_STRING variable is not set
Expected Behavior
Don't fail on missing env vars in comments
Steps to Reproduce
Run cloudquery sync with the provider configuration
Possible Solution
Ignore comments when expanding env variables
Provider and CloudQuery version
cloudquery version 2.1.0
Additional Context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels