Merged
Conversation
erezrokah
reviewed
Jun 27, 2025
Member
erezrokah
left a comment
There was a problem hiding this comment.
I would put this behind an option if possible, since it's likely we have existing tests that will break after this change.
Or maybe release it and see what happens when we update to the SDK 🙈
Contributor
Author
|
I did a search for the hard coded values I changed to be dynamic, and the only place it is used is in the filetypes tests, which I will manually update once this is released |
erezrokah
approved these changes
Jun 27, 2025
murarustefaan
approved these changes
Jun 27, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 30, 2025
🤖 I have created a release *beep* *boop* --- ## [4.86.0](v4.85.0...v4.86.0) (2025-06-30) ### Features * Make more data dynamic ([#2197](#2197)) ([57d0285](57d0285)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#2201](#2201)) ([aad5137](aad5137)) * **deps:** Update module github.com/apache/arrow-go/v18 to v18.3.1 ([#2199](#2199)) ([7f27c56](7f27c56)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.13.10 ([#2200](#2200)) ([a9f5dc1](a9f5dc1)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.26.14 ([#2203](#2203)) ([29d53f3](29d53f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes more fields dynamic, based on the random number seed. The data stays deterministic, but enables each row to have a different value