feat: Make NewSourceClient (and dest) as one interface#208
Merged
yevgenypats merged 7 commits intomainfrom Sep 30, 2022
Merged
Conversation
hermanschaaf
suggested changes
Sep 30, 2022
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
hermanschaaf
approved these changes
Sep 30, 2022
yevgenypats
pushed a commit
that referenced
this pull request
Sep 30, 2022
🤖 I have created a release *beep* *boop* --- ## [0.11.2](v0.11.1...v0.11.2) (2022-09-30) ### Features * Make NewSourceClient (and dest) as one interface ([#208](#208)) ([841a81b](841a81b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
yevgenypats
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 30, 2022
PluginManager abstraction is not needed anymore. makes less prop drilling and less code. see cloudquery/plugin-sdk#208
yevgenypats
added a commit
to cloudquery/cloudquery
that referenced
this pull request
Sep 30, 2022
PluginManager abstraction is not needed anymore. makes less prop drilling and less code. see cloudquery/plugin-sdk#208 <!-- Explain what problem this PR addresses --> <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Test locally on your own infrastructure - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅ ---> Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
This was referenced Oct 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I think I finally nailed the Client interface. This will remove completely the need for "PluginManager" in the CLI and yet another abstraction layer and prop drilling with WithOptions duplicates for every abstraction layer.
Also, the SDK is aware of
registry,pathandversionso I really think it should be here. it turns the CLI intro real CLI finally.