feat(schema): Add schema.TypeTimeInterval#205
Conversation
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. One question - maybe we should call it interval? i.e stick to postgresql types? or at least be consistent with one db? as in the json when it is being sent over the wire it is string anyway.
hermanschaaf
left a comment
There was a problem hiding this comment.
LGTM 👍
Let's mark it as a breaking change though, because destination plugins will need to explicitly handle this new type.
I think for destination plugin we need to always default to text as this field can contain anything and we shouldn't break destinations every-time we support new field in CQ. So I wouldn't mark it as breaking even it will break:) maybe just follow-up PR with the right behaviour to default to text? |
|
Now it'll be treated as As for the interval - will do |
🤖 I have created a release *beep* *boop* --- ## [0.11.3](v0.11.2...v0.11.3) (2022-09-30) ### Features * **schema:** Add schema.TypeDuration ([#205](#205)) ([02fce2c](02fce2c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary
Add duration column type for #178
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)