fix: Added custom toCamel, toSnake implementation#171
fix: Added custom toCamel, toSnake implementation#171amanenk merged 13 commits intocloudquery:mainfrom
Conversation
# Conflicts: # codegen/options.go # codegen/table_test.go
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks good 👍 I wonder: should this be internal to the sdk? We also use the strcase library in the plugin codegen packages, e.g. here: https://github.com/cloudquery/cloudquery/blob/main/plugins/source/aws/codegen/recipes/base.go#L99 and here: https://github.com/cloudquery/cloudquery/blob/main/plugins/source/aws/codegen/recipes/base.go#L113-L116
So would it maybe be better to recommend using our official implementation from the plugin-sdk, since we've fixed a few of the bugs? In that case, it shouldn't be internal here.
The other thing: maybe we should call this caser or something similar, since it now does more than just snake case 🙂
|
I have moved the package to a separate repo. |
|
@amanenk Oh, I didn't actually mean it should be in a different repo--let's keep it in plugin-sdk for now to get the benefit of CI and linting etc--I just meant it shouldn't be under the |
|
I see. will fix it now |
🤖 I have created a release *beep* *boop* --- ## [0.9.1](v0.9.0...v0.9.1) (2022-09-27) ### Bug Fixes * Added custom toCamel, toSnake implementation ([#171](#171)) ([f28e208](f28e208)) * **cli:** Added more informative error when there is no config files ([#179](#179)) ([a7ab327](a7ab327)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary
Since there is no way to cover all the acronyms, the functionality of acronyms customization added. Also some popular acronyms are taken from golang linter as default.
closes #159
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)