Skip to content

feat: Support DeleteRecord in all writers#1295

Merged
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom
bbernays:add-delete-record-to-writers
Oct 16, 2023
Merged

feat: Support DeleteRecord in all writers#1295
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom
bbernays:add-delete-record-to-writers

Conversation

@bbernays
Copy link
Copy Markdown
Contributor

Summary


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2023

⏱️ Benchmark results

Comparing with db72682

  • Glob-8 ns/op: 90.96 ⬇️ 113.17% decrease vs. db72682

bbernays and others added 2 commits October 16, 2023 09:01
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
@bbernays bbernays requested review from disq and hermanschaaf October 16, 2023 14:05
@bbernays bbernays requested review from disq and hermanschaaf October 16, 2023 14:51
@kodiakhq kodiakhq bot merged commit 5a02e27 into cloudquery:main Oct 16, 2023
@bbernays bbernays deleted the add-delete-record-to-writers branch October 16, 2023 14:59
kodiakhq bot pushed a commit that referenced this pull request Oct 16, 2023
🤖 I have created a release *beep* *boop*
---


## [4.14.0](v4.13.0...v4.14.0) (2023-10-16)


### Features

* Support DeleteRecord in all writers ([#1295](#1295)) ([5a02e27](5a02e27))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants