fix: Serialize columns during package#1270
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Oct 5, 2023
Merged
Conversation
yevgenypats
approved these changes
Oct 5, 2023
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Oct 5, 2023
#### Summary Along with cloudquery/plugin-sdk#1270 this fixes the missing columns for tables during publish (we only need to update the Go client to get the new model we unmarshal, see https://github.com/cloudquery/cloudquery-api-go/pull/25/files#diff-1edd75be97030ae0efe21c3bbaa6f62a7b4cf00cb0df07bb060e669fd3124698R373 https://github.com/cloudquery/cloudquery/blob/285d10d01b75e49e0a7cf9e83b24ee4a3e341553/cli/cmd/publish.go#L218 <!--
⏱️ Benchmark results
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
🤖 I have created a release *beep* *boop* --- ## [4.12.2](v4.12.1...v4.12.2) (2023-10-05) ### Bug Fixes * Serialize columns during package ([#1270](#1270)) ([cd5f79d](cd5f79d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hydratim
pushed a commit
to hydratim/cloudquery
that referenced
this pull request
Oct 20, 2023
#### Summary Along with cloudquery/plugin-sdk#1270 this fixes the missing columns for tables during publish (we only need to update the Go client to get the new model we unmarshal, see https://github.com/cloudquery/cloudquery-api-go/pull/25/files#diff-1edd75be97030ae0efe21c3bbaa6f62a7b4cf00cb0df07bb060e669fd3124698R373 https://github.com/cloudquery/cloudquery/blob/285d10d01b75e49e0a7cf9e83b24ee4a3e341553/cli/cmd/publish.go#L218 <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Columns were missing from
tables.json. This adds a dependency on https://github.com/cloudquery/cloudquery-api-go.I think that's fine since we already indirectly depend on it through https://github.com/cloudquery/plugin-pb-go
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)