fix: Correct error message on Read failure (#1680)

disq · pull[bot] · commit c1a8fa346316 · 2024-07-19T10:26:02.000Z
`failed to sync records: %w` is already used, by `Server.Sync()`

Co-authored-by: Kemal Hadimli &lt;disq@users.noreply.github.com&gt;
diff --git a/internal/servers/plugin/v3/plugin.go b/internal/servers/plugin/v3/plugin.go
@@ -79,7 +79,7 @@ func (s *Server) Init(ctx context.Context, req *pb.Init_Request) (*pb.Init_Respo
 
 func (s *Server) Read(req *pb.Read_Request, stream pb.Plugin_ReadServer) error {
 	records := make(chan arrow.Record)
-	var syncErr error
+	var readErr error
 	ctx := stream.Context()
 
 	sc, err := pb.NewSchemaFromBytes(req.Table)
@@ -94,7 +94,7 @@ func (s *Server) Read(req *pb.Read_Request, stream pb.Plugin_ReadServer) error {
 		defer close(records)
 		err := s.Plugin.Read(ctx, table, records)
 		if err != nil {
-			syncErr = fmt.Errorf("failed to sync records: %w", err)
+			readErr = fmt.Errorf("failed to read records: %w", err)
 		}
 	}()
 
@@ -111,7 +111,7 @@ func (s *Server) Read(req *pb.Read_Request, stream pb.Plugin_ReadServer) error {
 		}
 	}
 
-	return syncErr
+	return readErr
 }
 
 func (s *Server) Sync(req *pb.Sync_Request, stream pb.Plugin_SyncServer) error {

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ func (s Server) Init(ctx context.Context, req pb.Init_Request) (*pb.Init_Respo`
`79`	`79`
`80`	`80`	`func (s Server) Read(req pb.Read_Request, stream pb.Plugin_ReadServer) error {`
`81`	`81`	`records := make(chan arrow.Record)`
`82`		`- var syncErr error`
	`82`	`+ var readErr error`
`83`	`83`	`ctx := stream.Context()`
`84`	`84`
`85`	`85`	`sc, err := pb.NewSchemaFromBytes(req.Table)`
`@@ -94,7 +94,7 @@ func (s Server) Read(req pb.Read_Request, stream pb.Plugin_ReadServer) error {`
`94`	`94`	`defer close(records)`
`95`	`95`	`err := s.Plugin.Read(ctx, table, records)`
`96`	`96`	`if err != nil {`
`97`		`- syncErr = fmt.Errorf("failed to sync records: %w", err)`
	`97`	`+ readErr = fmt.Errorf("failed to read records: %w", err)`
`98`	`98`	`}`
`99`	`99`	`}()`
`100`	`100`
`@@ -111,7 +111,7 @@ func (s Server) Read(req pb.Read_Request, stream pb.Plugin_ReadServer) error {`
`111`	`111`	`}`
`112`	`112`	`}`
`113`	`113`
`114`		`- return syncErr`
	`114`	`+ return readErr`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`func (s Server) Sync(req pb.Sync_Request, stream pb.Plugin_SyncServer) error {`