fix: Don't use built in String method

erezrokah · erezrokah · commit 734f49c14ba8 · 2023-01-17T10:41:24.000+02:00
diff --git a/specs/destination.go b/specs/destination.go
@@ -72,7 +72,7 @@ func (d *Destination) Validate() error {
 	return nil
 }
 
-func (d Destination) String() string {
+func (d Destination) VersionString() string {
 	if d.Registry != RegistryGithub {
 		return fmt.Sprintf("%s (%s@%s)", d.Name, d.Registry, d.Path)
 	}
diff --git a/specs/destination_test.go b/specs/destination_test.go
@@ -198,7 +198,7 @@ func TestDestinationUnmarshalSpecValidate(t *testing.T) {
 	}
 }
 
-func TestDestination_String(t *testing.T) {
+func TestDestination_VersionString(t *testing.T) {
 	type fields struct {
 		Name     string
 		Version  string
@@ -259,7 +259,7 @@ func TestDestination_String(t *testing.T) {
 				Path:     tt.fields.Path,
 				Registry: tt.fields.Registry,
 			}
-			if got := d.String(); got != tt.want {
+			if got := d.VersionString(); got != tt.want {
 				t.Errorf("Destination.String() = %v, want %v", got, tt.want)
 			}
 		})
diff --git a/specs/source.go b/specs/source.go
@@ -129,7 +129,7 @@ func (s *Source) Validate() error {
 	return nil
 }
 
-func (s Source) String() string {
+func (s Source) VersionString() string {
 	if s.Registry != RegistryGithub {
 		return fmt.Sprintf("%s (%s@%s)", s.Name, s.Registry, s.Path)
 	}
diff --git a/specs/source_test.go b/specs/source_test.go
@@ -190,7 +190,7 @@ func TestSourceUnmarshalSpecValidate(t *testing.T) {
 	}
 }
 
-func TestSpec_String(t *testing.T) {
+func TestSpec_VersionString(t *testing.T) {
 	type fields struct {
 		Name     string
 		Version  string
@@ -251,7 +251,7 @@ func TestSpec_String(t *testing.T) {
 				Path:     tt.fields.Path,
 				Registry: tt.fields.Registry,
 			}
-			if got := s.String(); got != tt.want {
+			if got := s.VersionString(); got != tt.want {
 				t.Errorf("Source.String() = %v, want %v", got, tt.want)
 			}
 		})

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ func (d *Destination) Validate() error {`
`72`	`72`	`return nil`
`73`	`73`	`}`
`74`	`74`
`75`		`-func (d Destination) String() string {`
	`75`	`+func (d Destination) VersionString() string {`
`76`	`76`	`if d.Registry != RegistryGithub {`
`77`	`77`	`return fmt.Sprintf("%s (%s@%s)", d.Name, d.Registry, d.Path)`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ func TestDestinationUnmarshalSpecValidate(t *testing.T) {`
`198`	`198`	`}`
`199`	`199`	`}`
`200`	`200`
`201`		`-func TestDestination_String(t *testing.T) {`
	`201`	`+func TestDestination_VersionString(t *testing.T) {`
`202`	`202`	`type fields struct {`
`203`	`203`	`Name string`
`204`	`204`	`Version string`
`@@ -259,7 +259,7 @@ func TestDestination_String(t *testing.T) {`
`259`	`259`	`Path: tt.fields.Path,`
`260`	`260`	`Registry: tt.fields.Registry,`
`261`	`261`	`}`
`262`		`- if got := d.String(); got != tt.want {`
	`262`	`+ if got := d.VersionString(); got != tt.want {`
`263`	`263`	`t.Errorf("Destination.String() = %v, want %v", got, tt.want)`
`264`	`264`	`}`
`265`	`265`	`})`
Original file line number	Diff line number	Diff line change
`@@ -129,7 +129,7 @@ func (s *Source) Validate() error {`
`129`	`129`	`return nil`
`130`	`130`	`}`
`131`	`131`
`132`		`-func (s Source) String() string {`
	`132`	`+func (s Source) VersionString() string {`
`133`	`133`	`if s.Registry != RegistryGithub {`
`134`	`134`	`return fmt.Sprintf("%s (%s@%s)", s.Name, s.Registry, s.Path)`
`135`	`135`	`}`
Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ func TestSourceUnmarshalSpecValidate(t *testing.T) {`
`190`	`190`	`}`
`191`	`191`	`}`
`192`	`192`
`193`		`-func TestSpec_String(t *testing.T) {`
	`193`	`+func TestSpec_VersionString(t *testing.T) {`
`194`	`194`	`type fields struct {`
`195`	`195`	`Name string`
`196`	`196`	`Version string`
`@@ -251,7 +251,7 @@ func TestSpec_String(t *testing.T) {`
`251`	`251`	`Path: tt.fields.Path,`
`252`	`252`	`Registry: tt.fields.Registry,`
`253`	`253`	`}`
`254`		`- if got := s.String(); got != tt.want {`
	`254`	`+ if got := s.VersionString(); got != tt.want {`
`255`	`255`	`t.Errorf("Source.String() = %v, want %v", got, tt.want)`
`256`	`256`	`}`
`257`	`257`	`})`