fix: Set default download directory to .cq (#230)

erezrokah · web-flow · commit 689f5ed0299d · 2022-10-03T14:57:44.000Z
Currently plugins are downloaded to `CWD/plugins/*`. This PR changes it so they are downloaded to `CWD/.cq/plugins/*`

---
diff --git a/clients/destination.go b/clients/destination.go
@@ -62,7 +62,7 @@ func WithDestinationGrpcConn(userConn *grpc.ClientConn) func(*DestinationClient)
 func NewDestinationClient(ctx context.Context, registry specs.Registry, path string, version string, opts ...DestinationClientOption) (*DestinationClient, error) {
 	var err error
 	c := &DestinationClient{
-		directory: "./",
+		directory: DefaultDownloadDir,
 	}
 	for _, opt := range opts {
 		opt(c)
diff --git a/clients/download.go b/clients/download.go
@@ -16,6 +16,7 @@ type PluginType string
 const (
 	PluginTypeSource      PluginType = "source"
 	PluginTypeDestination PluginType = "destination"
+	DefaultDownloadDir               = ".cq"
 )
 
 func DownloadPluginFromGithub(ctx context.Context, localPath string, org string, name string, version string, typ PluginType, writers ...io.Writer) error {
diff --git a/clients/source.go b/clients/source.go
@@ -68,7 +68,7 @@ func WithSourceWriters(writers ...io.Writer) func(*SourceClient) {
 func NewSourceClient(ctx context.Context, registry specs.Registry, path string, version string, opts ...SourceClientOption) (*SourceClient, error) {
 	var err error
 	c := &SourceClient{
-		directory: "./",
+		directory: DefaultDownloadDir,
 	}
 	for _, opt := range opts {
 		opt(c)

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ func WithDestinationGrpcConn(userConn grpc.ClientConn) func(DestinationClient)`
`62`	`62`	`func NewDestinationClient(ctx context.Context, registry specs.Registry, path string, version string, opts ...DestinationClientOption) (*DestinationClient, error) {`
`63`	`63`	`var err error`
`64`	`64`	`c := &DestinationClient{`
`65`		`- directory: "./",`
	`65`	`+ directory: DefaultDownloadDir,`
`66`	`66`	`}`
`67`	`67`	`for _, opt := range opts {`
`68`	`68`	`opt(c)`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ type PluginType string`
`16`	`16`	`const (`
`17`	`17`	`PluginTypeSource PluginType = "source"`
`18`	`18`	`PluginTypeDestination PluginType = "destination"`
	`19`	`+ DefaultDownloadDir = ".cq"`
`19`	`20`	`)`
`20`	`21`
`21`	`22`	`func DownloadPluginFromGithub(ctx context.Context, localPath string, org string, name string, version string, typ PluginType, writers ...io.Writer) error {`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func WithSourceWriters(writers ...io.Writer) func(*SourceClient) {`
`68`	`68`	`func NewSourceClient(ctx context.Context, registry specs.Registry, path string, version string, opts ...SourceClientOption) (*SourceClient, error) {`
`69`	`69`	`var err error`
`70`	`70`	`c := &SourceClient{`
`71`		`- directory: "./",`
	`71`	`+ directory: DefaultDownloadDir,`
`72`	`72`	`}`
`73`	`73`	`for _, opt := range opts {`
`74`	`74`	`opt(c)`