fix(test): Slice rows properly when reading in tests (#1632)

candiduslynx · web-flow · commit 537b64c6ca2f · 2024-04-12T18:47:00.000Z
We never actually required the read records to be a single-row ones, so we may as well slice them ourselves
diff --git a/plugin/plugin_read.go b/plugin/plugin_read.go
@@ -18,8 +18,16 @@ func (p *Plugin) readAll(ctx context.Context, table *schema.Table) ([]arrow.Reco
 	// nolint:prealloc
 	var records []arrow.Record
 	for record := range ch {
-		records = append(records, record)
+		records = append(records, sliceToSingleRowRecord(record)...)
 	}
 
 	return records, err
 }
+
+func sliceToSingleRowRecord(record arrow.Record) []arrow.Record {
+	result := make([]arrow.Record, record.NumRows())
+	for i := int64(0); i < record.NumRows(); i++ {
+		result[i] = record.NewSlice(i, i+1)
+	}
+	return result
+}
