fix: Fix Destination testing suite (#417)

yevgenypats · web-flow · commit 4771efadf9c5 · 2022-11-20T11:25:25.000Z
Seems we weren't running some tests. I had to invert the variables which actually also make sense so they will be enabled by default. Let's say we add a new test this will detect if a plugin is not supporting a new mode.
diff --git a/plugins/destination_test.go b/plugins/destination_test.go
@@ -13,11 +13,7 @@ import (
 func TestDestinationPlugin(t *testing.T) {
 	p := NewDestinationPlugin("test", "development", NewTestDestinationMemDBClient)
 	DestinationPluginTestSuiteRunner(t, p, nil,
-		DestinationTestSuiteTests{
-			Overwrite:   true,
-			DeleteStale: true,
-			Append:      true,
-		})
+		DestinationTestSuiteTests{})
 }
 
 func TestDestinationOnNewError(t *testing.T) {
diff --git a/plugins/destination_testing.go b/plugins/destination_testing.go
@@ -19,9 +19,9 @@ type destinationTestSuite struct {
 }
 
 type DestinationTestSuiteTests struct {
-	Overwrite   bool
-	DeleteStale bool
-	Append      bool
+	SkipOverwrite   bool
+	SkipDeleteStale bool
+	SkipAppend      bool
 }
 
 func getTestLogger(t *testing.T) zerolog.Logger {
@@ -106,7 +106,7 @@ func (s *destinationTestSuite) destinationPluginTestWriteOverwrite(ctx context.C
 		return fmt.Errorf("expected data to be %v, got %v", resource.Data, resourcesRead[1])
 	}
 
-	if s.tests.DeleteStale {
+	if !s.tests.SkipDeleteStale {
 		if err := p.DeleteStale(ctx, tables, sourceName, secondSyncTime); err != nil {
 			return fmt.Errorf("failed to delete stale data second time: %w", err)
 		}
@@ -199,7 +199,7 @@ func DestinationPluginTestSuiteRunner(t *testing.T, p *DestinationPlugin, spec i
 
 	t.Run("TestWriteOverwrite", func(t *testing.T) {
 		t.Helper()
-		if suite.tests.Overwrite {
+		if suite.tests.SkipOverwrite {
 			t.Skip("skipping TestWriteOverwrite")
 			return
 		}
@@ -210,7 +210,7 @@ func DestinationPluginTestSuiteRunner(t *testing.T, p *DestinationPlugin, spec i
 
 	t.Run("TestWriteAppend", func(t *testing.T) {
 		t.Helper()
-		if suite.tests.Append {
+		if suite.tests.SkipAppend {
 			t.Skip("skipping TestWriteAppend")
 			return
 		}

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,9 @@ type destinationTestSuite struct {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`type DestinationTestSuiteTests struct {`
`22`		`- Overwrite bool`
`23`		`- DeleteStale bool`
`24`		`- Append bool`
	`22`	`+ SkipOverwrite bool`
	`23`	`+ SkipDeleteStale bool`
	`24`	`+ SkipAppend bool`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`func getTestLogger(t *testing.T) zerolog.Logger {`
`@@ -106,7 +106,7 @@ func (s *destinationTestSuite) destinationPluginTestWriteOverwrite(ctx context.C`
`106`	`106`	`return fmt.Errorf("expected data to be %v, got %v", resource.Data, resourcesRead[1])`
`107`	`107`	`}`
`108`	`108`
`109`		`- if s.tests.DeleteStale {`
	`109`	`+ if !s.tests.SkipDeleteStale {`
`110`	`110`	`if err := p.DeleteStale(ctx, tables, sourceName, secondSyncTime); err != nil {`
`111`	`111`	`return fmt.Errorf("failed to delete stale data second time: %w", err)`
`112`	`112`	`}`
`@@ -199,7 +199,7 @@ func DestinationPluginTestSuiteRunner(t testing.T, p DestinationPlugin, spec i`
`199`	`199`
`200`	`200`	`t.Run("TestWriteOverwrite", func(t *testing.T) {`
`201`	`201`	`t.Helper()`
`202`		`- if suite.tests.Overwrite {`
	`202`	`+ if suite.tests.SkipOverwrite {`
`203`	`203`	`t.Skip("skipping TestWriteOverwrite")`
`204`	`204`	`return`
`205`	`205`	`}`
`@@ -210,7 +210,7 @@ func DestinationPluginTestSuiteRunner(t testing.T, p DestinationPlugin, spec i`
`210`	`210`
`211`	`211`	`t.Run("TestWriteAppend", func(t *testing.T) {`
`212`	`212`	`t.Helper()`
`213`		`- if suite.tests.Append {`
	`213`	`+ if suite.tests.SkipAppend {`
`214`	`214`	`t.Skip("skipping TestWriteAppend")`
`215`	`215`	`return`
`216`	`216`	`}`