feat: Allow passing an auth token when downloading Hub plugins#138
Merged
kodiakhq[bot] merged 3 commits intomainfrom Oct 26, 2023
Merged
feat: Allow passing an auth token when downloading Hub plugins#138kodiakhq[bot] merged 3 commits intomainfrom
kodiakhq[bot] merged 3 commits intomainfrom
Conversation
erezrokah
commented
Oct 26, 2023
| typ PluginType | ||
| }{ | ||
| {testName: "should download test plugin from cloudquery registry", team: "cloudquery", plugin: "test", version: "v3.1.11", typ: PluginSource}, | ||
| {testName: "should download test plugin from cloudquery registry", team: "cloudquery", plugin: "azuredevops", version: "v3.0.12", typ: PluginSource}, |
Member
Author
There was a problem hiding this comment.
The test plugin is private so we can't download it without an auth token. It worked before due to a bug we fixed
erezrokah
commented
Oct 26, 2023
| tmpDir := t.TempDir() | ||
| cfg := Config{ | ||
| Name: "test", | ||
| Name: "azuredevops", |
Member
Author
There was a problem hiding this comment.
The test plugin is private so we can't download it without an auth token. It worked before due to a bug we fixed
disq
reviewed
Oct 26, 2023
Co-authored-by: Kemal <223029+disq@users.noreply.github.com>
disq
approved these changes
Oct 26, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
🤖 I have created a release *beep* *boop* --- ## [1.13.0](v1.12.3...v1.13.0) (2023-10-26) ### Features * Allow passing an auth token when downloading Hub plugins ([#138](#138)) ([b9f491d](b9f491d)) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to dbcb149 ([#130](#130)) ([e91be81](e91be81)) * **deps:** Update github.com/cloudquery/arrow/go/v14 digest to f46436f ([#137](#137)) ([f92d39c](f92d39c)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.2.9 ([#133](#133)) ([866eb55](866eb55)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.3.0 ([#134](#134)) ([5ba2f68](5ba2f68)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.4.0 ([#135](#135)) ([9d8001d](9d8001d)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.4.1 ([#136](#136)) ([6e1bef2](6e1bef2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to https://github.com/cloudquery/cloudquery-issues/issues/737 (internal issue).
This should unlock paid plugins downloads from the Hub. CLI PR coming in a bit
Use the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)