This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Merged
Conversation
89a3f07 to
cf926be
Compare
cf926be to
8a422a4
Compare
08f2ad5 to
d158fbd
Compare
cbabc70 to
a546806
Compare
Co-authored-by: Kemal <223029+disq@users.noreply.github.com>
…r-sdk into feat/smart_limiter
disq
suggested changes
Feb 8, 2022
Contributor
Author
|
@disq I didn't blindly cast to int64 - https://github.com/cloudquery/cq-provider-sdk/pull/184/files#diff-0e3b5cd2e6abf4633712dbd2d69307b7fbd75bc71844e34306afdcd9840dab64R182 (maybe I didn't push right away as there was a conflict in my local git) |
disq
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds another option called
max_goroutinesto keep the number of goroutines at hand and not OOM when having huge amount of projects or accounts.