This repository was archived by the owner on Aug 16, 2022. It is now read-only.
fix: Move mock generation to separate files#409
Merged
hermanschaaf merged 1 commit intocloudquery:mainfrom Jul 12, 2022
Merged
Conversation
yevgenypats
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, there was a mix between build strings in
services.goand in the separate service files. This ambiguity also seems to have resulted in a bug (#408), which this change fixes.I tested it by deleting all the files in the mocks directory and regenerating them using
make generate-mocks, which resulted in no changes according to git.Closes #408