This repository was archived by the owner on Aug 16, 2022. It is now read-only.
feat: Add tags for Glue Databases#1420
Closed
travwarren wants to merge 1 commit intocloudquery:mainfrom
Closed
Conversation
6 tasks
Member
|
Hi @travwarren and thank you for the PR 🎉 You've caught us in a middle of a migration to a monorepo, and the code for the AWS provider is now here. I've recreated your PR (using your commits) in cloudquery/cloudquery#1326 so we can continue the work there. You can also recreate it yourself if you'd like |
Member
|
Closing in favor of cloudquery/cloudquery#1326, we do any follow up work there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tags for Glue databases
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)go run ./docs/docs.goand committing the changes 📃