Skip to content
This repository was archived by the owner on Aug 16, 2022. It is now read-only.

feat: Add support for AWS SES Template#1133

Merged
candiduslynx merged 5 commits intocloudquery:mainfrom
candiduslynx:feature/ses/template
Jul 4, 2022
Merged

feat: Add support for AWS SES Template#1133
candiduslynx merged 5 commits intocloudquery:mainfrom
candiduslynx:feature/ses/template

Conversation

@candiduslynx
Copy link
Copy Markdown
Contributor

@candiduslynx candiduslynx commented Jun 30, 2022 •
edited
Loading

Summary

Implement AWS SES Template support (#783).

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@candiduslynx candiduslynx changed the title Feature/ses/template feat: Add support for AWS SES Template Jul 2, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2022

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output

Terraform Plan success

Show Plan

Pusher: @candiduslynx, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

5 similar comments
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2022

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output

Terraform Plan success

Show Plan

Pusher: @candiduslynx, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2022

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output

Terraform Plan success

Show Plan

Pusher: @candiduslynx, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2022

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output

Terraform Plan success

Show Plan

Pusher: @candiduslynx, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2022

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output

Terraform Plan success

Show Plan

Pusher: @candiduslynx, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2022

Terraform Format and Style success

Terraform Initialization success

Terraform Validation success

Validation Output

Terraform Plan success

Show Plan

Pusher: @candiduslynx, Action: pull_request_target, Working Directory: ``, Workflow: terraform_plan

@candiduslynx candiduslynx marked this pull request as ready for review July 4, 2022 09:08
@candiduslynx candiduslynx requested review from a team and disq and removed request for a team July 4, 2022 09:08
@candiduslynx candiduslynx linked an issue Jul 4, 2022 that may be closed by this pull request
AWS::SES::Template #783
Closed
disq
disq reviewed Jul 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

irmatov
irmatov suggested changes Jul 4, 2022
View reviewed changes
@candiduslynx candiduslynx requested review from disq and irmatov July 4, 2022 12:42
@bbernays
Copy link
Copy Markdown
Contributor

bbernays commented Jul 4, 2022

I think we should actually be using SESV2 as there are a few capabilities that only exist in that version.
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/sesv2

@candiduslynx candiduslynx merged commit 59081a8 into cloudquery:main Jul 4, 2022
@candiduslynx candiduslynx deleted the feature/ses/template branch July 4, 2022 15:31
@cq-bot cq-bot mentioned this pull request Jul 4, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@disq disq disq approved these changes

@irmatov irmatov irmatov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AWS::SES::Template

4 participants

@candiduslynx @bbernays @disq @irmatov