Skip to content

test(yaml): Add simple YAML parsing test#969

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:fix/validate_providers_in_yaml
Jun 22, 2022
Merged

test(yaml): Add simple YAML parsing test#969
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:fix/validate_providers_in_yaml

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Jun 21, 2022

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Validate YAML parsing


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@erezrokah erezrokah force-pushed the fix/validate_providers_in_yaml branch 2 times, most recently from 24d5816 to 32dacdf Compare June 21, 2022 14:34
resources = ["slow_resource"]
}`

const testNoSource = `cloudquery {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved these to files for:

  1. Syntax highlighting
  2. Formatting
  3. Syntax validation

@erezrokah erezrokah marked this pull request as ready for review June 21, 2022 14:48
@erezrokah erezrokah requested review from a team and zagronitay and removed request for a team June 21, 2022 14:48
@erezrokah erezrokah force-pushed the fix/validate_providers_in_yaml branch from 35f9faf to f4b17f9 Compare June 22, 2022 08:03
@erezrokah erezrokah changed the title fix(yaml): Validate provider block test(yaml): Add simple YAML parsing test Jun 22, 2022
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Jun 22, 2022
@kodiakhq kodiakhq bot merged commit 1e39e6d into cloudquery:main Jun 22, 2022
@erezrokah erezrokah deleted the fix/validate_providers_in_yaml branch August 9, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants