Skip to content

feat: HCL->YAML#752

Closed
yevgenypats wants to merge 2 commits intomainfrom
feat/hcl_yaml2
Closed

feat: HCL->YAML#752
yevgenypats wants to merge 2 commits intomainfrom
feat/hcl_yaml2

Conversation

@yevgenypats
Copy link
Copy Markdown
Contributor

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

This PR is very much WIP, and Im not sure I'll have time to complete it so anyone who will work on this can either start from this PR or just use it as a reference.

This PR does the following main things:

  • Move from HCL to YAML
  • Use JSON Schema for validation instead of code or at least avoid it as much as possible.
  • Remove drift as it will be a lot of work to convert it to YAML and we can't support it right now anyway. We will introduce this again potentially when we will have the resources for maintaining/testing all transformation of terraform->cloudquery schema and use for both things like drift and running cloudquery policies on terraform data. More elaboration here

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run --new-from-rev main 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@yevgenypats yevgenypats changed the title Feat/hcl yaml2 feat: HCL->YAML May 23, 2022
@bbernays bbernays linked an issue May 26, 2022 that may be closed by this pull request
@disq disq self-assigned this Jun 13, 2022
@disq disq mentioned this pull request Jun 13, 2022
7 tasks
@disq disq closed this Jun 13, 2022
@yevgenypats yevgenypats deleted the feat/hcl_yaml2 branch August 15, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move from HCL to yaml

2 participants