fix(mssql)!: Fix JSON transformer & column types #7010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a41547d to
6e83ed0
Compare
erezrokah
requested changes
Jan 23, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
The change looks good, but can we add some tests to the unescape code?
erezrokah
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7001
BEGIN_COMMIT_OVERRIDE
fix(mssql): Change column types from
varchartonvarcharto properly store Unicode charactersBREAKING-CHANGE: Change column types from
varchartonvarcharto properly store Unicode charactersfix(mssql): Fix JSON transformer to store unescaped data
END_COMMIT_OVERRIDE